Add unified _MACRO_MSG macro for all message types#4
Open
AstrandPallas wants to merge 1 commit intoAarCon:mainfrom
Open
Add unified _MACRO_MSG macro for all message types#4AstrandPallas wants to merge 1 commit intoAarCon:mainfrom
AstrandPallas wants to merge 1 commit intoAarCon:mainfrom
Conversation
AarCon
requested changes
Feb 19, 2026
Owner
AarCon
left a comment
AarCon
left a comment
There was a problem hiding this comment.
Update the branch you're working on from main and resubmit. There's a lot of changes in here that I just merged from the optimizations branch that I don't want to double touch.
Adds _MACRO_MSG to EvMacroType and processUnifiedMacro() to
MacroAssembler. Supports TALKMSG, TALK_KEYWAIT, EASY_OBJ_MSG,
EASY_BOARD_MSG, and ADD_CUSTUM_WIN_LABEL via a single macro:
_MACRO_MSG('TYPE', 'bundle', 'label', 'text')
Old macros (_MACRO_TALKMSG etc.) still work for backward compat.
AstrandPallas
force-pushed
the
macro-msg
branch
from
d74639d to
bc322f4
Compare
AarCon
requested changes
Feb 28, 2026
Owner
AarCon
left a comment
AarCon
left a comment
There was a problem hiding this comment.
One change needed and it should work just fine
| self.fileName, msgTypeArg.line, msgTypeArg.column)) | ||
|
|
||
| unifiedTypeMap = { | ||
| 'TALKMSG': EvCmdType._TALKMSG, |
Owner
There was a problem hiding this comment.
I would change all of the keys for this to be the actual command name like "_TALKMSG".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ev_macro.py: Added_MACRO_MSGtoEvMacroTypeenum.evAssembler.py: AddedprocessUnifiedMacro()method toMacroAssemblerclass. Dispatches_MACRO_MSG('TYPE', 'bundle', 'label', 'text')calls by extracting the type string, mapping to the correspondingEvCmdType, and delegating toprocessTextMacro(). Supports TALKMSG, TALK_KEYWAIT, EASY_OBJ_MSG, EASY_BOARD_MSG, and ADD_CUSTUM_WIN_LABEL. Old per-type macros still work (backward compatible).Test plan
.evfile using_MACRO_MSG('TALKMSG', 'bundle', 'label', 'text')— verify identical output to_MACRO_TALKMSG('bundle', 'label', 'text')_MACRO_TALKMSGetc. still work unchanged